Fixes for latest react-native / metro-bundler#1332
Closed
tqc wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hey @tqx! |
Contributor
|
Fixed in e1b70c2 |
7 tasks
Contributor
|
closing this one since there is a fix for it. We could revisit how this is done in the future. @tqc has a good point of making separation between RN and node startup code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The react native packager does not support dynamic require calls (react/react-native#6391, react/metro#52). Previous versions would only fail if the dynamic require was actually called, but the latest version detects the invalid syntax during build.
This update adds a replacement entry point for react-native that does not include the node-specific code.