Initial Plugin Functionality #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add javascript select
Add tooltip
Group sanitization
Add composer.json
Add wysiwyg support
jjeaton
reviewed
Jul 4, 2017
| $index = $group->args['array_key']; | ||
| $field_key = $field_id . '[' . $index . ']'; | ||
|
|
||
| echo '<div class="cmb-row cmb-flexible-row" data-groupid="' . esc_attr( $group_name ) . '" data-groupindex="' . absint( $index ) . '">'; |
Contributor
There was a problem hiding this comment.
I'd prefer it if we could break out of PHP here, rather than repeating echo after echo. 🌴
Merged
Contributor
Author
|
Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains all the functionality for Flexible fields, including
$_POSTrequest and then applies sanitization callbacks to each field.The next step will be to identify any hanging bugs, add proper documentation, and separate out functions from one big final to a few smaller ones.