Repository navigation
Requirements: upgrade gitpython because of security issue - #8950
Merged
Merged
Conversation
- we are using py3.8 so we don't need to ignore gitpython anymore - upgrade to latest version because it fixes a security issue reported at gitpython-developers/GitPython#1409
stsewd
approved these changes
Feb 21, 2022
stsewd
left a comment
Member
There was a problem hiding this comment.
The issue was a ReDoS, we are executing all git commands inside a celery task and don't think we are using the affected code (directly at least).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a possible security concern gitpython-developers/GitPython#1409