Skip to content

Only output debug logging from RTD app - #6717

Merged
ericholscher merged 2 commits into
masterfrom
better-logging
Apr 16, 2020
Merged

ericholscher merged 2 commits into
masterfrom
better-logging

Conversation

@ericholscher

Copy link
Copy Markdown
Member

In normal settings only log INFO and above,
but in dev we should log DEBUG to console.
This should only output RTD debug messages though,
because others are only logging INFO and above via the logger.

In normal settings only log INFO and above,
but in dev we should log DEBUG to console.
This should only output RTD debug messages though,
because others are only logging INFO and above via the logger.
@ericholscher
ericholscher requested a review from a team February 27, 2020 17:50

@humitos humitos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what changed (maybe a Django2 thing?) that this started being an issue now.

Change looks good to me, just asking if the DEBUG log level still works. We may want to just kill it, otherwise. I'm not sure if we are really using it though.

Comment on lines 623 to +624
# Always send from the root, handlers can filter levels
'level': 'DEBUG',
'level': 'INFO',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the root logger filters by INFO, can we set DEBUG level in the handler later? With this change, is DEBUG logging under debug.log file still working?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to be able to log DEBUG messages, but only from our application. So we want DEBUG to be output, but only sent via the RTD app, not all libraries.

@ericholscher
ericholscher merged commit 09c6450 into master Apr 16, 2020
@ericholscher
ericholscher deleted the better-logging branch April 16, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants