fix #92#99
Merged
erunion merged 4 commits intoreadmeio:masterfrom Jul 1, 2020
Merged
Conversation
Contributor
Author
|
notice pls: need a build |
erunion
reviewed
Jun 8, 2020
|
|
||
| return outputResult(swagger, options); | ||
| }).catch(e => { | ||
| console.error(e); |
Member
There was a problem hiding this comment.
Thoughts on throwing the error instead of putting it in the console?
Contributor
Author
There was a problem hiding this comment.
yep updated.
throwing it will be better than exit process directly.
Toolchains not triggers because I edited it on github web page lol. Thought it will be a small fix but found it wrong😆.
Btw wrote a test case to cover process exit code.
Member
|
Not sure why tests aren't building against this, but running them locally it's all good. |
# Conflicts: # package-lock.json
erunion
approved these changes
Jul 1, 2020
erunion
added a commit
that referenced
this pull request
Jul 1, 2020
Member
|
Published into v3.1.1. Thanks again for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi i've fixed #92 that error not be captured and process always exit with zero return code