Adding support for tabs along with spaces for inline comments#252
Merged
erunion merged 1 commit intoreadmeio:mainfrom Mar 17, 2022
Merged
Adding support for tabs along with spaces for inline comments#252erunion merged 1 commit intoreadmeio:mainfrom
erunion merged 1 commit intoreadmeio:mainfrom
Conversation
- replace \t characters with four spaces when using the` jsYaml.load()` method
Contributor
Author
|
@erunion understand that this does not replace a /t instances any thoughts here? Have also tried |
Member
|
@garrett-wade Not sure I'm familiar |
erunion
approved these changes
Mar 17, 2022
Contributor
Author
|
@erunion ran some more testing and looks like it needs to be |
Member
|
k, I'll add that in a follow up commit |
Member
Contributor
Author
|
@erunion just double checking, are you going to make the update or should I do another PR? Thanks for the timely responses here too. |
Member
|
@garrett-wade i already did and it's in that release! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial enhancement for the this issue.
This enhancement
\tcharacters with four spaces prior to loading the yaml the js-yaml library.Testing
Create a file with an inline
@oascomment and use tabs instead of spaces when specifying the underlying yaml and run a swagger-inline command on that file.