refactor: remove readable-stream polyfill#429
Merged
kanadgupta merged 1 commit intoesm-and-cjsfrom Sep 27, 2023
Merged
Conversation
kanadgupta
added
dependencies
kanadgupta
added a commit
that referenced
this pull request
Sep 27, 2023
* feat: enable TS strict mode * feat: exports for ESM and CJS * fix: don't lint before tests * fix: try splitting out types from default export * chore: more tsconfig refreshes * fix: this was the goddamn issue!!!! * feat: migrate package to ESM, everything works 🥹 * chore: lint fixes * chore(deps): remove unused dep * chore(deps): bump a bunch * ci: add pretest script * revert: don't lint in tests * chore: run prettier on everything * ci: small refactor * fix: bump target down Co-Authored-By: Ilias Tsangaris <[email protected]> * refactor: move type-checks into function itself * revert: build this repo in CJS instead that way we can use the conditional require syntax! * chore: clean up eslint config * chore: bump a few more deps * chore: bring back this rule * chore: test type cleanup * chore: silence TS error * fix: whoops remove the write flag * test: add `msw` tests (#428) * chore(deps): bump @vitest/browser to latest * test: add MSW tests * chore: rename test (server) implies the existence of (client), which isn't a thing 😔 * refactor: remove readable-stream polyfill (#429) * chore: add `files` array * chore: ope clean up an unused type * Update README.md Co-authored-by: Dom Harrington <[email protected]> * chore: add webpack thingy * fix: edit tsconfig.json see here: https://www.totaltypescript.com/tsconfig-cheat-sheet#not-transpiling-with-typescript * chore: bring back prebuild script ... because i don't trust tsup lol --------- Co-authored-by: Ilias Tsangaris <[email protected]> Co-authored-by: Dom Harrington <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
ReadableStreamhas been a thing in modern browsers for a while, and since this library now requires Node 18 or higher, I think it's safe to assume we can remove the polyfill?🧬 QA & Testing
Tests still appear to pass, though we apparently haven't been running browser tests for a while 😬