You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this PR is giving me a surprising amount of grief, which I believe is a tsup bug 😬
if the cjsInterop is not included in the tsup config:
the CJS types don't match the actual function signature (i.e., TS only types fetchHAR if the require statement is const fetchHAR = require('.').default; when the actual JS code will only run if it's const fetchHAR = require('.').default;. this is correctly getting flagged by attw:
if the cjsInterop: truein the tsup config:
attempting to run a CJS file with the package loaded via CJS just... doesn't work at all. it seems to be an issue with how tsup is constructing the module.exports — if I comment out the last line in the CJS dist file, it works properly:
TS appears to be consistent with the typing at least, and attw agrees:
feels like a frustrating two-steps-forward-two-steps-back dance here, so I'm going to close this out and I might create an issue in tsup at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Builds on #425 to build exports for both CJS and ESM.