feat(inputGroup): add InputGroup#99
Conversation
Resolves reactstrap#74 Add InputGroup with size prop Add InputGroupAddon Change Input to add addon prop for radio/checkbox to not `add form-check-input` class Add InputGroupButton with convinence shorthand when only a single string is passed Add tests for all of the above Add documention
|
Changes Unknown when pulling b3231a1 on TheSharpieOne:feature/input-group into * on reactstrap:master*. |
1 similar comment
|
Changes Unknown when pulling b3231a1 on TheSharpieOne:feature/input-group into * on reactstrap:master*. |
| const propTypes = { | ||
| tag: PropTypes.oneOfType([PropTypes.func, PropTypes.string]), | ||
| children: PropTypes.node, | ||
| groupClassName: PropTypes.any, |
There was a problem hiding this comment.
Been thinking about these one off props. They seem fine for now. Do you think that something like tags, props and classNames would help define a common pattern for this kind of stuff? ex: classNames={{group, button}}, props={{group: groupAttrs}}.
There was a problem hiding this comment.
Yeah, definitely. I like the props since className is just a prop, one could do props={{group: {className: 'yo'}}} to get that there without a special prop just for it.
I can change this in a future PR to match that pattern if you want to go that way.
|
|
3 participants
Resolves #74
Add
InputGroupwithsizepropAdd
InputGroupAddonChange Input to add
addonprop for radio/checkbox to not addform-check-inputclassAdd
InputGroupButtonwith convinence shorthand when only a single string is passedAdd tests for all of the above
Add documention