fix(FormGroup,Label): Fix inline radio- and checkboxes #624
Merged
TheSharpieOne merged 2 commits intoreactstrap:masterfrom Oct 7, 2017
clentfort:fix/inline-on-wrong-component
Merged
fix(FormGroup,Label): Fix inline radio- and checkboxes #624TheSharpieOne merged 2 commits intoreactstrap:masterfrom clentfort:fix/inline-on-wrong-component
TheSharpieOne merged 2 commits intoreactstrap:masterfrom
clentfort:fix/inline-on-wrong-component
Conversation
Currently inline of radio- and checkboxes do not work, because the classes are applied on the wrong component. According to the [Bootstrap documentation](https://getbootstrap.com/docs/4.0/components/forms/#inline) they should be applied to the containing `FormGroup` and not to the `Label`-element.
clentfort
changed the title
clentfort
changed the title
TheSharpieOne
approved these changes
Oct 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently inline of radio- and checkboxes do not work, because the classes
are applied on the wrong component. According to the Bootstrap
documentation
they should be applied to the containing
FormGroupand not to theLabel-element.