feat(outline): Make outline a separate prop#62
Merged
eddywashere merged 2 commits intoreactstrap:masterfrom Jul 28, 2016
Merged
feat(outline): Make outline a separate prop#62eddywashere merged 2 commits intoreactstrap:masterfrom
eddywashere merged 2 commits intoreactstrap:masterfrom
Conversation
The outline for buttons and cards is now it's own props separate from the color value. Based on reactstrap#33 (comment)
Member
|
@TheSharpieOne thanks a ton for the prs! I think this is acceptable behavior. I think card already has a solid style without background variants applied where as the default re: warnings/errors. I'd love to throw warnings in dev mode that catch issues like this and not include those warnings in production builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The outline for buttons and cards is now it's own props separate from the color value.
Based on #33 (comment)
This also adds additional tests around this new props.
Also:
Cards, unlike buttons, do not have a default color. Thus adding outline prop to a card without a color will do nothing.
Is this acceptable? Should it produce a warning/error? Should it default to 'card-outline-secondary' when outline is provided but no color is provided?