fix(popperjs): fixed error in build#571
Merged
TheSharpieOne merged 1 commit intoreactstrap:v5from Sep 13, 2017
Merged
Conversation
Fixed Error 'placements' is not exported by node_modules/popper.js/dist/esm/popper.js Renamed Popper to PopperContent in Tooltip.js to match Popover.js.
Member
|
Good catch. Can you also update Popover to be the same? |
Contributor
Author
|
@TheSharpieOne I fixed both tooltips and popovers in the original commit. I'm running the v5 branch locally now and popovers and tooltips are working great. This should be ready to merge. |
Member
|
Sorry, I missed that |
virgofx
pushed a commit
to virgofx/reactstrap
that referenced
this pull request
Sep 29, 2017
Fixed Error 'placements' is not exported by node_modules/popper.js/dist/esm/popper.js Renamed Popper to PopperContent in Tooltip.js to match Popover.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed build error: 'placements' is not exported by node_modules/popper.js/dist/esm/popper.js
Renamed
PoppertoPopperContentinTooltip.jsto matchPopover.js.