Skip to content

docs(Badge) update and fix docs#538

Merged
TheSharpieOne merged 1 commit intoreactstrap:v5from
mtakac:badge-docs-update
Sep 13, 2017
Merged

docs(Badge) update and fix docs#538
TheSharpieOne merged 1 commit intoreactstrap:v5from
mtakac:badge-docs-update

Conversation

@mtakac
Copy link
Copy Markdown
Contributor

@mtakac mtakac commented Aug 13, 2017

Remove default badge and update documentation so it's closer to bootstrap v4 beta
docs

Remove default badge and update documentation so it's closer to bootstrap v4 beta
docs
@mtakac
Copy link
Copy Markdown
Contributor Author

mtakac commented Aug 13, 2017

After Bootstrap 4 beta release default badge is not working anymore. Bootstrap documentation now uses secondary badges in the first example. I've done the same in Reactstrap docs. I also added few more examples from original bootstrap documentation.

One thing I am not sure about are links in badges. See original docs here. Should we create a whole new component or maybe add new prop to badge component to allow badge links or should they be created the same way as in Bootstrap: by adding a className to link? Also do we even want to include them in Reactstrap documentation?

@TheSharpieOne TheSharpieOne changed the base branch from master to v5 September 13, 2017 17:20
@TheSharpieOne TheSharpieOne merged commit db245a7 into reactstrap:v5 Sep 13, 2017
@TheSharpieOne
Copy link
Copy Markdown
Member

Thanks for this. I'm going handle the link the same as how Button works, if there is an href and the tag is defaulted, it will become an anchor tag.
Also, as for the default... I am going to just default it to secondary for now. I know you had mentioned in #539 that it should not default to anything and be required, but I am split about it and am erring on the side of not making a breaking change. If anything I would probably keep defaulting it to 'secondary' and add a deprecation message.

virgofx pushed a commit to virgofx/reactstrap that referenced this pull request Sep 29, 2017
Remove default badge and update documentation so it's closer to bootstrap v4 beta
docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants