Skip to content

docs(Alert): update docs#537

Merged
TheSharpieOne merged 1 commit intoreactstrap:v5from
mtakac:alert-docs-update
Sep 13, 2017
Merged

docs(Alert): update docs#537
TheSharpieOne merged 1 commit intoreactstrap:v5from
mtakac:alert-docs-update

Conversation

@mtakac
Copy link
Copy Markdown
Contributor

@mtakac mtakac commented Aug 13, 2017

Update Alert documentation to stay up to date with bootstrap v4 beta.
Add light and dark colors and add examples with Link color and
Additional content.

Update Alert documentation to stay up to date with bootstrap v4 beta.
Add light and dark colors and add examples with Link color and
Additional content.
@mtakac
Copy link
Copy Markdown
Contributor Author

mtakac commented Aug 13, 2017

I noticed some changes in Bootstrap v4 beta documentation and I think it could be helpful to update Reactstrap documentation according to these changes. This PR does it for Alerts. I'll gladly continue with other components if you think it will be useful.

I am not entirely sure if Reactstrap documentation should include also examples that are in Bootstrap, but have nothing to do with React components. See alerts with links and alerts with additional content in this PR. Any thoughts about this?

@TheSharpieOne
Copy link
Copy Markdown
Member

I think reactstrap's examples should match bootstrap's examples one-to-one.

@TheSharpieOne TheSharpieOne changed the base branch from master to v5 September 13, 2017 17:13
@TheSharpieOne TheSharpieOne merged commit 6ce79ff into reactstrap:v5 Sep 13, 2017
virgofx pushed a commit to virgofx/reactstrap that referenced this pull request Sep 29, 2017
Update Alert documentation to stay up to date with bootstrap v4 beta.
Add light and dark colors and add examples with Link color and
Additional content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants