fix(DropdownToggle, NavbarToggler, Tooltip): Pass through cssModule to child components#483
fix(DropdownToggle, NavbarToggler, Tooltip): Pass through cssModule to child components#483TheSharpieOne merged 1 commit intoreactstrap:masterfrom ajs139:css_modules_fixes
Conversation
|
|
||
| return ( | ||
| <Tag {...attributes} className={classes} /> | ||
| <Tag {...attributes} cssModule={cssModule} className={classes} /> |
There was a problem hiding this comment.
Here the default Tag is div, in which case the cssModules prop would not want to be passed down
|
I like what you are trying to do here, and you definitely exposed a pretty large issue with the way |
|
Thanks for the feedback, I see exactly what you mean. I've removed the changes to ButtonGroup. The other three changes seem, less problematic, is that right? I'll give more thought to the ButtonGroup and if I come up with anything I'll let you know. |
|
@TheSharpieOne - on reflection, I'm not sure changing ButtonGroup was the right plan anyway. The idea was to be able to give ButtonGroup a CSS Module that would style its child components, but I think this will really be easy when webpack/css-loader#520 is resolved. Please let me know if you need anything else from me. |
|
Hi guys, thank you all for this fix. @TheSharpieOne when we can expect this fix in npm release? :) |
Trying to use CSS Modules proved problematic for a few of the components. These changes pass through the CSS Module to the child component when appropriate.