👍

We should also add bundle size as a step in the build process, like this: https://github.com/developit/vhtml/blob/master/package.json#L13

@balloob If the references to react-transition-group imported via ES6 imports instead of cherrypicking would we need the cherrypicked references ?

e.g. Change: import CSSTransitionGroup from 'react-transition-group/CSSTransitionGroup'; to import { CSSTransitionGroup } from 'react-transition-group';.

If so, I'd argue that's the more normalized solution (Updating the few locations that use the package) and then just leaving one single top level package global/exclude.

The older documentation referenced cherry picking but was recently updated to use proper ES imports:
https://github.com/reactjs/react-transition-group#high-level-api-csstransitiongroup

@virgofx good point. I have addressed your comments 👍

@nathancahill I will leave that up to a future PR. Opened issue #475 to discuss it.

@TheSharpieOne You've commented variations of your comment at three different spots. I will respond to all of them here.

You state that every lib ever is pointing at unbundled files. However, React will ship bundled by Rollup as a single build for both development and production starting React 16: https://unpkg.com/[email protected]/index.js See this talk by one of the Facebook React maintainers at ReactEurope about how the size and load times both went down with 10%: https://youtu.be/djOc1EK07Tk?t=300

Since lib/index.js will import every component, there is no cherry picking going on. If you want to cherry-pick without using modules, you have to import from lib/Card.js etc, which is still very much possible. Importing lib/index.js however will contain everything as per the source. This means that importing lib/index.js is equivalent to the compiled bundle, except that the Babel helpers will be part of each individually transpiled file. Take for example lib/CardDeck.js, a third of the code is BabelHelpers: _extends, _interopRequireDefault, _objectWithoutProperties. This averages a 500 byte cost per file, which with 70 components results in 39kB extra being shipped to users of Reactstrap. That's a 42% increase over the compiled file size.

The warning was because the 4.6 bundle was broken and actually included the whole of React in the compiled bundle! #433 didn't fix it, it just hid the problem for npm users while still having a broken build for UMD users. This PR will fix the build again and no warning will be issued.

When with react 16, they generate cjs and umd, right now and with your changes there is only umd with reactstrap. React 16 doesn't reference the umd output in their package.json.
Maybe you need to create another file and point to that, just don't point to the umd output as that is most certainly wrong.
Since size is the main concern (not just simply not including dependencies which should not be included) take a look at cjs vs umd file sizes in react 16, at least a 10% different in output size.
They also have development builds which help users step through troubleshooting locally.

That can be tweaked by marking lodash.omit and lodash.tonumber as external for a CJS build. Would save us 10kB.

Feel free to submit that as a followup PR once this one has been merged.

This PR saves 240kB for UMD bundles and 29-39kB* for CommonJS bundles. On top of that the loading time will be faster due to the flat bundle that Rollup creates.

*: 39kB for only including the Babel helpers once. Up to 10kB of waste if consumer also depends on lodash.omit.

@TheSharpieOne I have reverted the change to main. No reason to delay fixing the ES/UMD bundles over a discussion about the CJS entrypoint.

#477 includes this PR and creates a CommonJS build without any dependency included.