Skip to content

fix(Navbar): Fixes #463 by ensuring that the default role is now empty#464

Merged
eddywashere merged 4 commits intoreactstrap:masterfrom
virgofx:fix-navbar-role
Jun 27, 2017
Merged

fix(Navbar): Fixes #463 by ensuring that the default role is now empty#464
eddywashere merged 4 commits intoreactstrap:masterfrom
virgofx:fix-navbar-role

Conversation

@virgofx
Copy link
Copy Markdown
Collaborator

@virgofx virgofx commented Jun 10, 2017

fix(Navbar): Fixes #463 by ensuring that the default role is now empty for nav elements.

@virgofx
Copy link
Copy Markdown
Collaborator Author

virgofx commented Jun 10, 2017

The default is now not set, which allows for opt-in; however, that would still allow and end-user to specify role=navigation with a nav tag. ... which is invalid. I'm not sure if we should force HTML5 compliance (e.g. end users would be frustrated that we drop a potential prop in this case where it's invalid) .... OR we can leave as is, where the defaults are empty, any explicit props will override ... and we could potentially update the default role to show for non nav elements if one is not specified.

@eddywashere Thoughts?

@virgofx
Copy link
Copy Markdown
Collaborator Author

virgofx commented Jun 17, 2017

ping @eddywashere

@eddywashere eddywashere merged commit f607b2c into reactstrap:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navbar component should no longer use 'navigation' as default role

2 participants