Fix(Dropdown, TetherContent): add touchstart event to TetherContent, …#456
Closed
Arsolio wants to merge 3 commits intoreactstrap:masterfrom
Closed
Fix(Dropdown, TetherContent): add touchstart event to TetherContent, …#456Arsolio wants to merge 3 commits intoreactstrap:masterfrom
Arsolio wants to merge 3 commits intoreactstrap:masterfrom
Conversation
Member
|
Is it ever possible to trigger both events or is it always one or the other? I've seen reference to using |
|
@eddywashere Hi! I also looked into this issue for sometime and here are some notes you might find useful:
I haven't tested old Android versions but the statement above is true on 6.x and 7.x. In conclusion, I think this PR is legit and I will be happy to see it get merged. (Currently I'm using the |
TheSharpieOne
approved these changes
Jul 27, 2017
virgofx
pushed a commit
to virgofx/reactstrap
that referenced
this pull request
Sep 29, 2017
fixes dropdowns, tooltips, and popovers not triggers on touch events Closes reactstrap#456 reactstrap#458
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just added touchstart event to fix issue with toggle for iOS devices.
Closes #458