add onOpened and onClosed callbacks for modals#434
Merged
TheSharpieOne merged 4 commits intoreactstrap:masterfrom Jul 14, 2017
Merged
add onOpened and onClosed callbacks for modals#434TheSharpieOne merged 4 commits intoreactstrap:masterfrom
TheSharpieOne merged 4 commits intoreactstrap:masterfrom
Conversation
Contributor
Author
|
@eddywashere @virgofx would you be able to review / comment on this? |
TheSharpieOne
approved these changes
Jul 14, 2017
Member
TheSharpieOne
left a comment
TheSharpieOne
left a comment
There was a problem hiding this comment.
LGTM
This is a breaking change since onEnter and onExit props do not do the same thing as they did before.
This was referenced Jul 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #306
Also re-ordered the propTypes in the example to match the order of the source code.