Skip to content

chore(dist): fix release#433

Merged
eddywashere merged 1 commit intoreactstrap:masterfrom
TheSharpieOne:chore/fix-main
May 16, 2017
Merged

chore(dist): fix release#433
eddywashere merged 1 commit intoreactstrap:masterfrom
TheSharpieOne:chore/fix-main

Conversation

@TheSharpieOne
Copy link
Copy Markdown
Member

@TheSharpieOne TheSharpieOne commented May 15, 2017

fixes #430 and #432. This uses the generated lib files when requiring/importing from npm module (not not using treeshaking (webpack1)). This does NOT fix the dist/ files (such as the UMD build) being generated incorrectly.

@will-stone
Copy link
Copy Markdown

Hi, when will this fix be merged/released?

@th3fallen
Copy link
Copy Markdown

@eddywashere is this going to be tagged as a release?

@TheSharpieOne TheSharpieOne deleted the chore/fix-main branch May 16, 2017 18:00
@eddywashere
Copy link
Copy Markdown
Member

eddywashere commented May 16, 2017

@will-stone @th3fallen released as 4.6.2

thanks again @TheSharpieOne!

@th3fallen
Copy link
Copy Markdown

@eddywashere thanks for that, have you received this error since the release? Cannot find module 'react-transition-group/TransitionGroup' from 'Modal.js'

@eddywashere
Copy link
Copy Markdown
Member

@th3fallen not seeing that output in tests. the peer deps recently changed. Can you make sure react-transition-group is installed? New install instructions are: npm install --save reactstrap react-transition-group react react-dom. feel free to update changelog with this upgrade info if it helps.

@th3fallen
Copy link
Copy Markdown

yeah, that was it manually installing fixed, it i was literally on the way here to post that but you beat me to it.

@balloob
Copy link
Copy Markdown
Contributor

balloob commented Jun 23, 2017

This fix is incorrect. By pointing it at the lib, you're now having people include a 300kB version of Reactstrap instead of 91kB. Each individual lib file contains a copy of the React helpers, resulting in their size being ~3x as big.

#474 is the right fix. I will include a revert of this PR in that fix.

balloob pushed a commit to balloob/reactstrap that referenced this pull request Jun 23, 2017
@TheSharpieOne
Copy link
Copy Markdown
Member Author

@balloob that is incorrect, as reference please see every other library ever made. For those using non es modules, this is the way it is done. There is another property in the package.json for es modules.

eddywashere pushed a commit that referenced this pull request Jun 27, 2017
…big file size) (#474)

* Externalize ReactTransitionGroup

* Update transition group imports

* Revert incorrect fix #433

* Revert change to main and fix in future PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[4.6.1] Pointing to minified react causes warning

5 participants