chore(dist): fix release#433
Conversation
|
Hi, when will this fix be merged/released? |
|
@eddywashere is this going to be tagged as a release? |
|
@will-stone @th3fallen released as 4.6.2 thanks again @TheSharpieOne! |
|
@eddywashere thanks for that, have you received this error since the release? Cannot find module 'react-transition-group/TransitionGroup' from 'Modal.js' |
|
@th3fallen not seeing that output in tests. the peer deps recently changed. Can you make sure |
|
yeah, that was it manually installing fixed, it i was literally on the way here to post that but you beat me to it. |
|
This fix is incorrect. By pointing it at the lib, you're now having people include a 300kB version of Reactstrap instead of 91kB. Each individual lib file contains a copy of the React helpers, resulting in their size being ~3x as big. #474 is the right fix. I will include a revert of this PR in that fix. |
|
@balloob that is incorrect, as reference please see every other library ever made. For those using non es modules, this is the way it is done. There is another property in the package.json for es modules. |
fixes #430 and #432. This uses the generated lib files when requiring/importing from npm module (not not using treeshaking (webpack1)). This does NOT fix the dist/ files (such as the UMD build) being generated incorrectly.