fix(ButtonDropdown) group={false} did nothing#425
Merged
eddywashere merged 6 commits intoreactstrap:masterfrom May 14, 2017
Merged
fix(ButtonDropdown) group={false} did nothing#425eddywashere merged 6 commits intoreactstrap:masterfrom
eddywashere merged 6 commits intoreactstrap:masterfrom
Conversation
The underlying Object.assign needs to have the overrides to the right it seems like
```function example(){
let props = {group: "FROM PROPERTIES" };
let propsOverwritten = Object.assign({}, props, {'group': "group from defaults"});
console.log("props first, groups overwritten", propsOverwritten);
let notOverwritten = Object.assign({}, {'group': "group from defaults"}, props);
console.log("groups first, overwritten by props as intended", notOverwritten);
}
example()
```
ES6 example https://es6console.com/j2paoelc/
Not crazy sure, but I changed the order in `reactstrap.es.js` of `g,{group:!0}` and it worked, so this seems like it would have the appropriate affect.
Contributor
Author
|
Thanks for catching the space error, I missed that one too! |
Member
|
@tankorsmash if you're looking to conditionally change the ButtonDropdown to a normal dropdown, I would recommend importing Dropdown and doing the check there. Also, this component could likely go away in a future release to simplify component list. |
Contributor
Author
|
@eddywashere No worries, I was purely trying to get rid of the group class because I have the button alone in a div. If you need to prune the component that's totally fine on my end, thanks! |
tankorsmash
added a commit
to tankorsmash/Leagion
that referenced
this pull request
May 16, 2017
…oup (pending MR on reactstrap) reactstrap/reactstrap#425
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying Object.assign needs to have the overrides to the right it seems like
ES6 example https://es6console.com/j2paoelc/
Not crazy sure, but I changed the order in
reactstrap.es.jsofg,{group:!0}and it worked, so this seems like it would have the appropriate affect.