move to external react-transition-group dependency#399
Merged
eddywashere merged 2 commits intoreactstrap:masterfrom May 14, 2017
Merged
move to external react-transition-group dependency#399eddywashere merged 2 commits intoreactstrap:masterfrom
eddywashere merged 2 commits intoreactstrap:masterfrom
Conversation
ened
force-pushed
the
react-transition-group
branch
from
f53cff0 to
6fca069
Compare
This was referenced Apr 21, 2017
Closed
Contributor
Author
|
Would love to know if anyone is using that patch already? |
Contributor
|
Yes, I tested it, but I use Rollup, so I can't speak for the Webpack changes. It works fine otherwise. Would love to see this merged soon, currently a blocker for upgrading to latest React. |
Contributor
Author
|
@eddywashere Hi there, could you please give us an update? Thank you |
|
Please merge this PR ASAP. The deprecated dependencies are no longer installing and it's breaking our app. Thanks, |
Member
|
@samrod that is not how deprecations work. |
|
Any status updates regarding this PR? |
TheSharpieOne
approved these changes
May 5, 2017
Contributor
Author
|
.oO( time to fork ) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html:
Please review the webpack.base.config.js changes whether it needs changes.