fix(*): import PropTypes from prop-types#395
Conversation
|
Awesome! will check this out later |
|
Bump the dependency to minimum of 15.5.7 per guides or better yet even 15.5.8 was released yesterday. |
|
@apaatsio By the way you can |
515f440 to
3cd5085
Compare
|
I updated the dependencies to follow the instructions at https://github.com/reactjs/prop-types#how-to-depend-on-this-package. Thanks @julien-f @ufocoder, I can see some benefits in readability but I'm not gonna go for that search-and-replace exercise. If someone wants to do it, go ahead. |
|
In the peer dependencies we still have |
|
reactstrap doesn't do complex things and for the more complex things, the API has been in react since 0.14.0, I would be surprised it didn't work with 0.14.0. prop-types on the other hand does not work with 0.14.0, the minimum version is 0.14.9. I would suggest changing the peerDep to |
Using the PropTypes via the react package is deprecated as of React 15.5.0. Use the PropTypes from the prop-types package as recommended. See https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html
|
@TheSharpieOne Thanks, I updated the dependencies. |
|
While we're doing this, we should also update from |
|
Nevermind, just saw #399 which is open for this. |
|
What's missing? May I help? @eddywashere can you merge this PR? |
|
Thanks @apaatsio! |
Using the PropTypes via the react package is deprecated as of React
15.5.0.
Use the PropTypes from the prop-types package as recommended.
See https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html