fix(Modal): Made focus optional#389
Merged
eddywashere merged 4 commits intoreactstrap:masterfrom May 14, 2017
miguelc1221:master
Merged
fix(Modal): Made focus optional#389eddywashere merged 4 commits intoreactstrap:masterfrom miguelc1221:master
eddywashere merged 4 commits intoreactstrap:masterfrom
miguelc1221:master
Conversation
Member
|
My two cents, isFocused is probably not the best name, something like autoFocus would be better. |
Contributor
Author
|
yea you're right, fixed. |
|
What is the status on this, is it going to be merged? |
Member
|
need to re-review and will ship it |
TheSharpieOne
approved these changes
May 5, 2017
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #335.
It seems that the Modal has a default autoFocus which is why any input inside the modal won't be autoFocused. I exposed a
isFocusedprop which defaults to true. This way if a user wants to autofocus an input, he/she can remove the autofocus from the modal first.