Add UMD builds to Rollup#386
Merged
eddywashere merged 1 commit intoreactstrap:masterfrom Apr 3, 2017
Merged
Conversation
Collaborator
|
Thanks, looking forward to next release to test 👍 |
Collaborator
|
4.5.0 works great now and existing CDN reference on main site can remain as is. Thanks for the UMD update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I incorrectly assumed that Webpack was exporting CommonJS syntax. Instead, it was exporting UMD format (which is CommonJS compatible).
So, this updates the Rollup config, also making it backwards compatible with Reactstrap 4.3.0 to address #359 (comment).
As extra bonus, the UMD bundles are able to be minified to 95kB! Looking at the source code, it seems like minifiers can do a better job minifying since everything is inside a function.
Changes:
reactstrap.cjs.jsoutputreactstrap.min.js(compatible with CommonJS and equivalent to output in Reactstrap 4.3)Testing changes
Point all the test files at the UMD bundle:
Run tests as usual:
npm test.