Fix import/export not getting transpiled in lib dir#384
Merged
eddywashere merged 2 commits intoreactstrap:masterfrom Apr 3, 2017
Merged
Conversation
Member
|
I would also point main in the package.json to the lib index.js as this would allow for better source maps and such. |
Contributor
Author
|
Nah, the source maps are already off since some transpilation happens. Instead I have added source maps back to the UMD output in #386 |
Contributor
Author
|
Another issue with the lib dir is that if you import from it, you will also have to add the dependencies of Reactstrap to your own |
Member
|
You shouldn't need to, reactstrap-tether is a dependency, not a peer or devDep. It will be downloaded when reactstrap is installed and things know how to resolve it. |
Contributor
Author
|
@TheSharpieOne ah yes, you're right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup conversion introduced a bug where Babel wouldn't transpile import/export to CommonJS syntax in the lib dir. This PR fixes it.
Report: #359 (comment)