Make toggle prop optional on Modal#325
Merged
eddywashere merged 2 commits intoreactstrap:masterfrom Feb 14, 2017
bherila:toggle-prop-optional
Merged
Make toggle prop optional on Modal#325eddywashere merged 2 commits intoreactstrap:masterfrom bherila:toggle-prop-optional
eddywashere merged 2 commits intoreactstrap:masterfrom
bherila:toggle-prop-optional
Conversation
Contributor
Author
|
@eddywashere what do you think? |
Member
|
+1 to this specifically. Will hold off on merging until I can ship a release and avoid any confusion with what's in master and what latest on npm |
TheSharpieOne
requested changes
Feb 13, 2017
Member
TheSharpieOne
left a comment
TheSharpieOne
left a comment
There was a problem hiding this comment.
👍 for making the propType not required, but there is logic that needs to also be updated.
Currently it assumes that this.props.toggle will always be present. With your change, that is not the case. You may want to default it to an noop or check that it is function before calling it (where it is being called)
Contributor
Author
|
Good call @TheSharpieOne , I fixed that. |
TheSharpieOne
approved these changes
Feb 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re #323