feat(Modal): add various className props to modal#320
Merged
eddywashere merged 1 commit intoreactstrap:masterfrom Feb 14, 2017
Merged
feat(Modal): add various className props to modal#320eddywashere merged 1 commit intoreactstrap:masterfrom
eddywashere merged 1 commit intoreactstrap:masterfrom
Conversation
TheSharpieOne
force-pushed
the
feature/modal-wrap-classname
branch
from
1bf410d to
1b328e5
Compare
Collaborator
|
👍 Thanks @TheSharpieOne |
Contributor
|
👍 please merge this, I could use it as well. Thanks @TheSharpieOne |
Member
|
Limited availability this week and last but will do so asap. Thanks! |
|
It would be really helpful, if this request could be merged (today would be the best...) and a release created |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #257
To help future proof this and prevent "cannot add class to ... on the modal", additional className props were also added.
I can adjust the naming or remove those if needed.