feat(Col): add custom widths ability to Col#309
Merged
eddywashere merged 1 commit intoreactstrap:masterfrom Jan 28, 2017
Merged
feat(Col): add custom widths ability to Col#309eddywashere merged 1 commit intoreactstrap:masterfrom
eddywashere merged 1 commit intoreactstrap:masterfrom
Conversation
TheSharpieOne
force-pushed
the
feature/custom-columns
branch
from
17500ae to
b6e2bf9
Compare
TheSharpieOne
force-pushed
the
feature/custom-columns
branch
from
b6e2bf9 to
a6cfcf1
Compare
eddywashere
reviewed
Jan 28, 2017
| }); | ||
|
|
||
| it('should allow custom columns to be defined with objects', () => { | ||
| const wrapper = shallow(<Col widths={['base', 'jumbo', 'wtf']} wtf={{ size: 1, push: 2, pull: 3, offset: 4 }} />); |
Member
There was a problem hiding this comment.
😆 just happy to have tests for this
eddywashere
reviewed
Jan 28, 2017
| } | ||
|
|
||
| const isXs = colWidth === 'xs'; | ||
| const isXs = !i; |
Member
Author
There was a problem hiding this comment.
Yeah, but I probably should have just went with i === 0 or something to be more clear. That's my bad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #297