Skip to content

Pass through unused props in Modal#254

Merged
eddywashere merged 1 commit intoreactstrap:masterfrom
DanielleHuisman:master
Dec 18, 2016
Merged

Pass through unused props in Modal#254
eddywashere merged 1 commit intoreactstrap:masterfrom
DanielleHuisman:master

Conversation

@DanielleHuisman
Copy link
Copy Markdown
Contributor

@DanielleHuisman DanielleHuisman commented Dec 17, 2016

Currently it's not possible to for example change the size (excluding default Bootstrap sizes) of modals. This change allows users to style the modal dialog.

@DanielleHuisman DanielleHuisman changed the title Added style property to Modal, which allows styling of div.modal-dialog Add style property to Modal, which allows styling of div.modal-dialog Dec 17, 2016
@TheSharpieOne
Copy link
Copy Markdown
Member

TheSharpieOne commented Dec 17, 2016

My 2 cents on this:
There is a size prop. Bootstrap comes with default sizes, you can override these. You can make your own custom sizes. Make a modal-my-size class and make it the size you want then set the size prop to my-size. There isn't really much need for the styles since there is bootstrap css framework and if you are not using bootstrap then you may want to find another library.

@DanielleHuisman
Copy link
Copy Markdown
Contributor Author

DanielleHuisman commented Dec 17, 2016 •
edited
Loading

This patch has more than just that specific use case, it was just an example. In my opinion it's important for a library, such as reacststrap, to support both CSS and inline styles. Almost all other components support passing style elements (some through ...otherProps), so why not support it here?

@TheSharpieOne
Copy link
Copy Markdown
Member

TheSharpieOne commented Dec 17, 2016

So... Apply the other props here as well

@DanielleHuisman DanielleHuisman changed the title Add style property to Modal, which allows styling of div.modal-dialog Pass through unused props in Modal Dec 17, 2016
@DanielleHuisman
Copy link
Copy Markdown
Contributor Author

DanielleHuisman commented Dec 17, 2016

Changed it.

@eddywashere
Copy link
Copy Markdown
Member

eddywashere commented Dec 18, 2016

This is a great improvement, thanks @DanielHuisman!

@eddywashere eddywashere merged commit a783308 into reactstrap:master Dec 18, 2016
@eddywashere eddywashere mentioned this pull request Dec 18, 2016
Merged
eddywashere pushed a commit that referenced this pull request Dec 18, 2016
@DanielleHuisman @eddywashere
feat(Modal): Pass through props in Modal (#254)
c99e873
@eddywashere eddywashere mentioned this pull request Dec 18, 2016
Merged
@eddywashere
Copy link
Copy Markdown
Member

eddywashere commented Dec 18, 2016

released in 3.9.5 and 4.0.0-alpha.5

@eddywashere eddywashere mentioned this pull request Jan 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielleHuisman @TheSharpieOne @eddywashere