Fixes rapid opening and closing of modal (Fade component fix) #166 #247

Merged

eddywashere merged 1 commit intoreactstrap:masterfrom

ajainarayanan:fix/ui-rapid-openclose-modal

Dec 12, 2016

Contributor

ajainarayanan commented Dec 3, 2016 •

edited

Loading

Not sure if this is the entire fix. But this fixed the error related to this issue (ReactTransitionGroup.js:116 Uncaught TypeError: Cannot read property 'componentDidAppear' of undefined facebook/react#5240).
A similar issue fixed in React (https://github.com/facebook/react/pull/5391/files) & MaterialUI ([Core] Remove isMounted() mui/material-ui#3437) ( source)

Fixes: #166


          Fixes rapid opening and closing of modal (Fade component fix)

19a90ac

intpp commented Dec 9, 2016

When it will be in master branch?

eddywashere merged commit 5e0f5d2 into reactstrap:master

Member

eddywashere commented Dec 12, 2016

Thanks @ajainarayanan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet