ListGroup doc #185#236
ListGroup doc #185#236eddywashere merged 10 commits intoreactstrap:masterfrom LiJinyao:ListGroup-doc
Conversation
# Conflicts: # docs/lib/Components/index.js # docs/lib/routes.js # webpack.dev.config.js
I use a color prop to pass contextual classes info to the component, when you want to set a status, you must type `color=“success”`. It trivially to do so. Now you just need pass a `success` bool prop to show the status.
|
@LiJinyao why remove |
|
@eddywashere Oh I haven't notice that it is a standard prop. I'll change it back. |
| </pre> | ||
|
|
||
|
|
||
| <h4>Container Properties</h4> |
There was a problem hiding this comment.
Can you remove the container docs from this
| ); | ||
|
|
||
| // Prevent click event when disabled. | ||
| if (disabled) { |
There was a problem hiding this comment.
I was going to ask to convert this to a normal component to make use of instance methods like onClick in Button but this is basically the same thing. Neat! I believe a new function is assigned each time it is rendered as disabled. Can you move this logic to a const handleDisabledOnClick that's assigned outside of the ListGroupItem function.
There was a problem hiding this comment.
OK，I'll do it as soon as possible :)
eddywashere
left a comment
eddywashere
left a comment
There was a problem hiding this comment.
Minor changes requested. This is looking great @LiJinyao!
2 participants
#185 Add ListGroup doc.
API Change in ListGroupItem component:
When I write doc, I found that using
color="success"to set contextual class is not a good idea.The
colorprop is no longer support, when you want to set a contextual class, just pass the name (one of “success”, “info”, “warning”, “danger”) to the component.Since this component is not exists in doc yet and just released a few days, I think the change is acceptable.