add NavbarToggler example#216
Merged
eddywashere merged 8 commits intoreactstrap:masterfrom Nov 2, 2016
Merged
Conversation
* init collapse * add collapse animation * add margin between toggle button and collapse * disable lint on force refresh DOM line. * add test to Collapse * remove height after shown * Revert "remove height after shown" This reverts commit eff9353. * remove height after shown. * add more test * use setState() to set inline height style * remove custom tag in doc * add inline style test * remove comment * set height to null when isOpen is true * add initial state test
eddywashere
reviewed
Nov 1, 2016
| <Navbar color="faded" light> | ||
| <NavbarBrand href="/">reactstrap</NavbarBrand> | ||
| <NavbarToggler className="float-sm-right hidden-lg-up collapsed" onClick={this.toggleNavbar} /> | ||
| <div className={classnames('collapse', 'navbar-toggleable-md', {in: !this.state.collapsed})}> |
Member
There was a problem hiding this comment.
Could you rebase this pr and use the new Collapse component?
* chore(release): adding 3.8.0 * feat(Collapse): add cssModule support
…nto NavbarToggler-example
eddywashere
reviewed
Nov 2, 2016
| <div className={classnames('collapse', 'navbar-toggleable-md', {in: !this.state.collapsed})}> | ||
| <Nav className="float-sm-left float-md-right" navbar> | ||
| <Collapse className="navbar-toggleable-md" isOpen={!this.state.collapsed}> | ||
| <NavbarBrand href="/">reactstrap</NavbarBrand> |
Member
There was a problem hiding this comment.
It's too bad BS4 doesn't support this being outside of the collapsible section. I imagine the toggle icon on one side and the brand on the other side. 👍
Contributor
Author
There was a problem hiding this comment.
I think it would support it with additional styling but I implemented it exactly like the sample on BS4's own docs for simplicity.
Member
There was a problem hiding this comment.
For sure. I'm holding off on documenting custom styles but I might do something like this for the docs site navbar. Thanks again for documenting this!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding a collapsible Navbar component example with NavbarToggler per #129