fix(events): use capture events#202
Merged
eddywashere merged 1 commit intoreactstrap:masterfrom Oct 25, 2016
Merged
Conversation
Member
|
+1. I thought I went through the few areas we're using events outside of SyntheticEvent to switch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to a previous issue where an event was triggered AFTER some DOM manipulation which caused the event logic to run after things changed. This really only impacted when the thing that triggered the event was no longer in the DOM which changed the flow and triggered things to happen.
It is probably best to globally do the same thing, which is to handle the event as soon as possible using
useCapture.