docs(Navs): Update nav dropdown markup#196
Merged
eddywashere merged 1 commit intomasterfrom Oct 22, 2016
Merged
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed an issue where the dropdown in nav (pills and tabs) were looking weird. It turns out it was using incorrect markup. Instead of nesting nav-link in the dropdown toggle, it should be combined. I’m not sure if this was part of alpha v5, or if the markup and classes were always off.
I’m hesitant to add a new component to simplify this or to add a prop to DropdownToggle to enable this common usage. For now, I’m updating the docs to use the built in flexibility of the existing dropdown toggle component.