fix(tooltip): fix when toggle is not provided#182
fix(tooltip): fix when toggle is not provided#182eddywashere merged 1 commit intoreactstrap:masterfrom
Conversation
Before, when props.toggle was not provided, this.toggle would throw Essentially when someone just provides the `isOpen` prop and wants to manaully control the hiding/showing.
|
👍 |
|
Should this be added to other components? |
|
Which other components? I looked at pop over and it did not work the same way. I mean, we could default some of the callback functions, but at a certain point, they are not explicitly used like it was here. |
|
That's right! Nothing to see here :) On Mon, Oct 17, 2016 at 8:24 PM Evan Sharp [email protected] wrote:
|
3 participants
Before, when props.toggle was not provided, this.toggle would throw
Essentially when someone just provides the
isOpenprop and wantsto manually control the hiding/showing.
onMouseOverTooltipwould triggershow, which would triggertogglewhen the tooltip was not being shown. Withouttoggleprop, it would error.