fix(Modal): Account for body padding when scrollbar is present#165
Merged
eddywashere merged 1 commit intomasterfrom Oct 1, 2016
Merged
fix(Modal): Account for body padding when scrollbar is present#165eddywashere merged 1 commit intomasterfrom
eddywashere merged 1 commit intomasterfrom
Conversation
Member
Author
|
Opened up an issue upstream to track the fixed content shift. twbs/bootstrap#20824 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, body and fixed navbars get pushed because of the modal-open class. This pr only fixes the regular body content. Need to look at how bootstrap does this for the fixed content.
Fixes part of #164.
Need to look at adjusting modal dialog as well.
Also I had a hard time getting tests in for this. Going leave those commented out for now.