Skip to content

Tooltip autohide prop#149

Merged
eddywashere merged 2 commits intomasterfrom
tooltip-autohide
Sep 19, 2016
Merged

Tooltip autohide prop#149
eddywashere merged 2 commits intomasterfrom
tooltip-autohide

Conversation

@eddywashere
Copy link
Copy Markdown
Member

Adds autohide prop to tooltip. When autohide is false, hovering over tooltip content will not close the tooltip.

example use case: UI needs to allow users a chance to copy content from tooltip content.

@eddywashere
Copy link
Copy Markdown
Member Author

Thought this already existed when I commented over here.

Comment thread src/Tooltip.js

return (
<TetherContent
onMouseOver={this.onMouseOverTooltip}
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra props are not part of the clone children stuff that goes on in TetherContent. I think it makes more sense to apply these event handlers to the children directly.

@eddywashere eddywashere merged commit 68a0ed7 into master Sep 19, 2016
@eddywashere eddywashere deleted the tooltip-autohide branch September 19, 2016 04:09
@eddywashere eddywashere mentioned this pull request Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant