Skip to content

feat(Modal): allow for multiple modals#138

Merged
eddywashere merged 1 commit intoreactstrap:masterfrom
TheSharpieOne:feature/modal-listener
Sep 14, 2016
Merged

feat(Modal): allow for multiple modals#138
eddywashere merged 1 commit intoreactstrap:masterfrom
TheSharpieOne:feature/modal-listener

Conversation

@TheSharpieOne
Copy link
Copy Markdown
Member

Resolves #137
Moves the click and keyup listeners from the document to the
.modal div, which wraps the modal-dialog. This allows for each
modal to be individually triggered to close.

Resolves reactstrap#137
Moves the click and keyup listeners from the document to the
`.modal` div, which wraps the modal-dialog. This allows for each
modal to be individually triggered to close.
@ajainarayanan
Copy link
Copy Markdown
Contributor

Tested it locally. Worked as expected 👍

Comment thread src/Modal.js
transitionAppearTimeout={300}
transitionEnterTimeout={300}
transitionLeaveTimeout={300}
onClickCapture={this.handleBackdropClick}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about onClickCapture 👍

@eddywashere
Copy link
Copy Markdown
Member

:shipit:

@eddywashere eddywashere merged commit 7ada8cf into reactstrap:master Sep 14, 2016
@TheSharpieOne TheSharpieOne deleted the feature/modal-listener branch September 28, 2016 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attach clickHandler on backdrop element instead of document

3 participants