fix(modal): fix event listener for modal#127
Merged
eddywashere merged 1 commit intoreactstrap:masterfrom Sep 8, 2016
Merged
Conversation
Fixes reactstrap#126 Change the event listeners for click and keyup in modal to set `useCapture` to true to trigger the handler before any other handler.
Member
|
I did not now about useCapture other than it was safer to use false. Makes way more sense now. Thanks for looking into this and fixing it. 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126
Change the event listeners for click and keyup in modal
to set
useCaptureto true to trigger the handler beforeany other handler.