Button & DropdownToggle updates#120
Merged
eddywashere merged 3 commits intomasterfrom Sep 6, 2016
Merged
Conversation
| <Helmet title="Dropdowns" /> | ||
| <h3>Dropdowns</h3> | ||
| <p> | ||
| The <code>Dropdown</code> component is used to pass the <code>isOpen</code> & <code>toggle</code> props via context to the following components: <code>DropdownToggle</code>, <code>DropdownMenu</code>. The <code>DropdownToggle</code> uses the <code>Button</code> component internally, meaning it also accepts all the props the <Link to="/components/buttons/">Button component</Link> accepts. |
Member
Author
There was a problem hiding this comment.
Also added Dropdown description and info around advanced positioning.
Member
Author
|
Besides the Button color deafult, this affects users who pass an array of children to Old example: <DropdownToggle>
<Button color="primary">Click Me</Button>
<Button color="primary">Or me!!</Button>
</DropdownToggle>Updated syntax: <DropdownToggle color="primary">Click Me</DropdownToggle>
<DropdownToggle color="primary">Or me!!</DropdownToggle>You could think of |
Member
Author
|
@arcanis thoughts? The following will now work <DropdownToggle>
<i className={`fa fa-user`} />
</DropdownToggle>this too: <DropdownToggle tag="i" className={`fa fa-user`} /> |
|
Looks much better 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some inconsistencies within button and dropdown components and removes some weird behavior found in #98.
secondary(previously default style in bs3)