chore(coverage): Update instrumenter#101
Merged
eddywashere merged 3 commits intoreactstrap:masterfrom Aug 18, 2016
Merged
Conversation
Replace isparta with istambul since isparta is no longer maintained See: https://github.com/douglasduteil/isparta Istambul now support es2015/6. (Also added cross-env to allow it to work on windows)
TheSharpieOne
force-pushed
the
chore/update-instrumenter
branch
from
4d07d5c to
64d148d
Compare
|
Changes Unknown when pulling 64d148d on TheSharpieOne:chore/update-instrumenter into * on reactstrap:master*. |
1 similar comment
|
Changes Unknown when pulling 64d148d on TheSharpieOne:chore/update-instrumenter into * on reactstrap:master*. |
| "dependencies": { | ||
| "babel-cli": "^6.11.4", | ||
| "classnames": "^2.2.3", | ||
| "cross-env": "^2.0.0", |
Member
There was a problem hiding this comment.
Can you move cross-env to devdeps? I know it's weird, but I was hoping to restrict dependencies to the core reactstrap library dependencies. I must have accidently added babel-cli to it.
Member
|
I think I should restrict tests to latest node version to avoid the double coverage reports. |
Member
Author
|
Yeah, not too sure why it is not about to determine the changes to the coverage either and the branches are "**"... strange. |
1 similar comment
| "react-dom": "^0.14.0 || ^15.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "babel-cli": "^6.11.4", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace isparta with istambul since isparta is no longer maintained
See: https://github.com/douglasduteil/isparta
Istambul now support es2015/6.
(Also added cross-env to allow it to work on windows)
This PR is not a big deal, just some maintenance, though I did notice the coverage output was slightly more detailed with the babel istambul plugin this PR adds than the isparta loader it replaces.