-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Comparing changes
Open a pull request
base repository: reactstrap/reactstrap
base: 4.5.0
head repository: reactstrap/reactstrap
compare: 4.6.0
- 13 commits
- 86 files changed
- 9 contributors
Commits on May 14, 2017
-
feat(Modal): Support fade and timeout props in the Modal component to…
… allow configuring + disabling of the fade effect (#339) * Support a fade=false prop in the Modal component - if fade=false, the following happens: - no 'fade' class is applied - the modal + backdrop transition timeouts become 0 - the transitionAppear, etc. booleans passed to Fade are false * Update fadeless-modal to not use the Fade component - This feels like a better design. If we are not doing a fade effect, why use a Fade component? - This also gets rid of the usage of TransitionGroup when fade={false}. - Ensure onEnter and onExit fire when expected. * DRY up shared code between fade-modal and fadeless-modal - Extract modalDialog rendering into a separate method - Simplify the variable setting in #renderChildren following the movement of several of them into #modalDialog * Make modalTransitionTimeout and backdropTransitionTimeout configurable as props - Update docs - Add test * Fix warning about missing context in DropdownMenu spec * Allow configuring appear v. enter v. leave timeouts separately
Configuration menu - View commit details
-
Copy full SHA for babee0f - Browse repository at this point
Copy the full SHA babee0fView commit details -
chore(lint): fix linter error (#418)
A new linter rule lines up with new browser spec prohibits a trailing comma after the rest syntax. Since there can be no variables defined after the rest, it is pointless to have a comma dangle there.
Configuration menu - View commit details
-
Copy full SHA for 45d991d - Browse repository at this point
Copy the full SHA 45d991dView commit details -
chore(tests): update test deps (#419)
This updates enzyme to remove the depractation Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning. keeping addon test utils for backwards compatibility until the min react version for this project is updated. Enzyme will use it if needed.
Configuration menu - View commit details
-
Copy full SHA for 33a4f5b - Browse repository at this point
Copy the full SHA 33a4f5bView commit details -
docs(Utilities): Add utilities panel including clearfix and color doc…
…umentation pages. (#381) * docs(Utilities): add utilities and color page * doce(Clearfix): add clearfix page in utilities
Configuration menu - View commit details
-
Copy full SHA for 0ffb819 - Browse repository at this point
Copy the full SHA 0ffb819View commit details -
fix(PropTypes): import PropTypes from prop-types (#395)
Using the PropTypes via the react package is deprecated as of React 15.5.0. Use the PropTypes from the prop-types package as recommended. See https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html
Configuration menu - View commit details
-
Copy full SHA for 9080217 - Browse repository at this point
Copy the full SHA 9080217View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4fec3c - Browse repository at this point
Copy the full SHA a4fec3cView commit details -
feat(Modal): add autoFocus prop for disabling auto focus (#389)
* fix(Modal): Made focus optional * set default focus to true * rename prop to autoFocus
Configuration menu - View commit details
-
Copy full SHA for 6338fc3 - Browse repository at this point
Copy the full SHA 6338fc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c137697 - Browse repository at this point
Copy the full SHA c137697View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ce004c - Browse repository at this point
Copy the full SHA 6ce004cView commit details -
fix(Modal): fix bug where closing modal removed wrong modal-open stri…
…ng in class (#410) Example: initial body class: `no-modal-opened` open and close modal, body class: `no-ed modal-open`
Configuration menu - View commit details
-
Copy full SHA for 22d5c3f - Browse repository at this point
Copy the full SHA 22d5c3fView commit details -
fix(ButtonDropdown): allow overwriting the group prop (#425)
* fix(ButtonDropdown) group={false} did nothing The underlying Object.assign needs to have the overrides to the right it seems like ```function example(){ let props = {group: "FROM PROPERTIES" }; let propsOverwritten = Object.assign({}, props, {'group': "group from defaults"}); console.log("props first, groups overwritten", propsOverwritten); let notOverwritten = Object.assign({}, {'group': "group from defaults"}, props); console.log("groups first, overwritten by props as intended", notOverwritten); } example() ``` ES6 example https://es6console.com/j2paoelc/ Not crazy sure, but I changed the order in `reactstrap.es.js` of `g,{group:!0}` and it worked, so this seems like it would have the appropriate affect. * fix extra space * add space to fix lint ruleConfiguration menu - View commit details
-
Copy full SHA for 663551b - Browse repository at this point
Copy the full SHA 663551bView commit details
Commits on May 15, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 8b379a4 - Browse repository at this point
Copy the full SHA 8b379a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ff73fa - Browse repository at this point
Copy the full SHA 2ff73faView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4.5.0...4.6.0