Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: reactstrap/reactstrap
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.5.0
Choose a base ref
...
head repository: reactstrap/reactstrap
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.6.0
Choose a head ref
  • 13 commits
  • 86 files changed
  • 9 contributors

Commits on May 14, 2017

  1. feat(Modal): Support fade and timeout props in the Modal component to…

    … allow configuring + disabling of the fade effect (#339)
    
    * Support a fade=false prop in the Modal component
    
    - if fade=false, the following happens:
      - no 'fade' class is applied
      - the modal + backdrop transition timeouts become 0
      - the transitionAppear, etc. booleans passed to Fade are false
    
    * Update fadeless-modal to not use the Fade component
    
    - This feels like a better design. If we are not doing
      a fade effect, why use a Fade component?
    - This also gets rid of the usage of TransitionGroup
      when fade={false}.
    - Ensure onEnter and onExit fire when expected.
    
    * DRY up shared code between fade-modal and fadeless-modal
    
    - Extract modalDialog rendering into a separate method
    - Simplify the variable setting in #renderChildren
      following the movement of several of them into
      #modalDialog
    
    * Make modalTransitionTimeout and backdropTransitionTimeout configurable as props
    
    - Update docs
    - Add test
    
    * Fix warning about missing context in DropdownMenu spec
    
    * Allow configuring appear v. enter v. leave timeouts separately
    Anne Johnson authored and eddywashere committed May 14, 2017
    Configuration menu
    Copy the full SHA
    babee0f View commit details
    Browse the repository at this point in the history
  2. chore(lint): fix linter error (#418)

    A new linter rule lines up with new browser spec prohibits a trailing comma after the rest syntax.
    Since there can be no variables defined after the rest, it is pointless to have a comma dangle there.
    TheSharpieOne authored and eddywashere committed May 14, 2017
    Configuration menu
    Copy the full SHA
    45d991d View commit details
    Browse the repository at this point in the history
  3. chore(tests): update test deps (#419)

    This updates enzyme to remove the depractation Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning.
    keeping addon test utils for backwards compatibility until the min react version for this project is updated. Enzyme will use it if needed.
    TheSharpieOne authored and eddywashere committed May 14, 2017
    Configuration menu
    Copy the full SHA
    33a4f5b View commit details
    Browse the repository at this point in the history
  4. docs(Utilities): Add utilities panel including clearfix and color doc…

    …umentation pages. (#381)
    
    * docs(Utilities): add utilities and color page
    
    * doce(Clearfix): add clearfix page in utilities
    shaaslam authored and eddywashere committed May 14, 2017
    Configuration menu
    Copy the full SHA
    0ffb819 View commit details
    Browse the repository at this point in the history
  5. fix(PropTypes): import PropTypes from prop-types (#395)

    Using the PropTypes via the react package is deprecated as of React
    15.5.0.
    
    Use the PropTypes from the prop-types package as recommended.
    
    See https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html
    apaatsio authored and eddywashere committed May 14, 2017
    Configuration menu
    Copy the full SHA
    9080217 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a4fec3c View commit details
    Browse the repository at this point in the history
  7. feat(Modal): add autoFocus prop for disabling auto focus (#389)

    * fix(Modal): Made focus optional
    
    * set default focus to true
    
    * rename prop to autoFocus
    miguelc1221 authored and eddywashere committed May 14, 2017
    Configuration menu
    Copy the full SHA
    6338fc3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c137697 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6ce004c View commit details
    Browse the repository at this point in the history
  10. fix(Modal): fix bug where closing modal removed wrong modal-open stri…

    …ng in class (#410)
    
    Example:
    initial body class: `no-modal-opened`
    open and close modal, body class: `no-ed modal-open`
    markogresak authored and eddywashere committed May 14, 2017
    Configuration menu
    Copy the full SHA
    22d5c3f View commit details
    Browse the repository at this point in the history
  11. fix(ButtonDropdown): allow overwriting the group prop (#425)

    * fix(ButtonDropdown) group={false} did nothing
    
    The underlying Object.assign needs to have the overrides to the right it seems like
    
    ```function example(){
      let props = {group: "FROM PROPERTIES" };
      let propsOverwritten = Object.assign({}, props, {'group': "group from defaults"});
      console.log("props first, groups overwritten", propsOverwritten);
      
      let notOverwritten = Object.assign({}, {'group': "group from defaults"}, props);
      console.log("groups first, overwritten by props as intended", notOverwritten);
    }
    
    
    example()
    ```
    
    ES6 example https://es6console.com/j2paoelc/
    
    Not crazy sure, but I changed the order in `reactstrap.es.js` of `g,{group:!0}` and it worked, so this seems like it would have the appropriate affect.
    
    * fix extra space
    
    * add space to fix lint rule
    tankorsmash authored and eddywashere committed May 14, 2017
    Configuration menu
    Copy the full SHA
    663551b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2017

  1. Configuration menu
    Copy the full SHA
    8b379a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ff73fa View commit details
    Browse the repository at this point in the history
Loading