Skip to content

Commit feb9a70

Browse files
TheSharpieOneeddywashere
authored andcommitted
feat(CardDeck): set flex as only option (#316)
1 parent 3cba887 commit feb9a70

3 files changed

Lines changed: 2 additions & 26 deletions

File tree

docs/lib/Components/CardPage.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,7 @@ CardColumns.propTypes = {
7171
CardDeck.propTypes = {
7272
// Pass in a Component to override default element
7373
tag: PropTypes.oneOfType([PropTypes.func, PropTypes.string]),
74-
className: PropTypes.string,
75-
// enable flexbox version of component (removes extra classes)
76-
flex: PropTypes.bool
74+
className: PropTypes.string
7775
};
7876
7977
CardFooter.propTypes = {

src/CardDeck.js

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,37 +6,26 @@ const propTypes = {
66
tag: PropTypes.oneOfType([PropTypes.func, PropTypes.string]),
77
className: PropTypes.string,
88
cssModule: PropTypes.object,
9-
flex: PropTypes.bool,
109
};
1110

1211
const defaultProps = {
1312
tag: 'div',
14-
flex: false
1513
};
1614

1715
const CardDeck = (props) => {
1816
const {
1917
className,
2018
cssModule,
2119
tag: Tag,
22-
flex,
2320
...attributes
2421
} = props;
2522
const classes = mapToCssModules(classNames(
2623
className,
2724
'card-deck'
2825
), cssModule);
2926

30-
if (flex) {
31-
return (
32-
<Tag {...attributes} className={classes} />
33-
);
34-
}
35-
3627
return (
37-
<div className="card-deck-wrapper">
38-
<Tag {...attributes} className={classes} />
39-
</div>
28+
<Tag {...attributes} className={classes} />
4029
);
4130
};
4231

src/__tests__/CardDeck.spec.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,32 +7,21 @@ describe('CardDeck', () => {
77
const wrapper = shallow(<CardDeck>Yo!</CardDeck>);
88

99
expect(wrapper.text()).toBe('Yo!');
10-
expect(wrapper.hasClass('card-deck-wrapper')).toBe(true);
1110
expect(wrapper.find('.card-deck').length).toBe(1);
1211
});
1312

1413
it('should render additional classes', () => {
1514
const wrapper = shallow(<CardDeck className="other">Yo!</CardDeck>);
1615

1716
expect(wrapper.find('.card-deck').hasClass('other')).toBe(true);
18-
expect(wrapper.hasClass('card-deck-wrapper')).toBe(true);
1917
expect(wrapper.find('.card-deck').length).toBe(1);
2018
});
2119

2220
it('should render custom tag', () => {
2321
const wrapper = shallow(<CardDeck tag="main">Yo!</CardDeck>);
2422

2523
expect(wrapper.text()).toBe('Yo!');
26-
expect(wrapper.hasClass('card-deck-wrapper')).toBe(true);
2724
expect(wrapper.find('.card-deck').length).toBe(1);
2825
expect(wrapper.find('main').length).toBe(1);
2926
});
30-
31-
it('should render without wrapper class when flexbox is enabled', () => {
32-
const wrapper = shallow(<CardDeck flex>Yo!</CardDeck>);
33-
34-
expect(wrapper.hasClass('card-deck-wrapper')).toBe(false);
35-
expect(wrapper.hasClass('card-deck')).toBe(true);
36-
expect(wrapper.text()).toBe('Yo!');
37-
});
3827
});

0 commit comments

Comments
 (0)