fix(Navbar): remove default navigation role

virgofx · eddywashere · commit f607b2cb5eaf · 2017-06-27T08:51:55.000-07:00
* fix(Navbar): Fixes #463 by ensuring that the default role is now empty for nav elements. * Updating tests. * Removing trailing spaces.
diff --git a/src/Navbar.js b/src/Navbar.js
@@ -19,7 +19,6 @@ const propTypes = {
 
 const defaultProps = {
   tag: 'nav',
-  role: 'navigation',
   toggleable: false,
 };
 
diff --git a/src/__tests__/Navbar.spec.js b/src/__tests__/Navbar.spec.js
@@ -6,31 +6,37 @@ describe('Navbar', () => {
   it('should render .navbar markup', () => {
     const wrapper = shallow(<Navbar />);
 
-    expect(wrapper.html()).toBe('<nav role="navigation" class="navbar"></nav>');
+    expect(wrapper.html()).toBe('<nav class="navbar"></nav>');
   });
 
   it('should render default .navbar-toggleable class', () => {
     const wrapper = shallow(<Navbar toggleable />);
 
-    expect(wrapper.html()).toBe('<nav role="navigation" class="navbar navbar-toggleable"></nav>');
+    expect(wrapper.html()).toBe('<nav class="navbar navbar-toggleable"></nav>');
   });
 
   it('should render size based .navbar-toggleable-* classes', () => {
     const wrapper = shallow(<Navbar toggleable="md" />);
 
-    expect(wrapper.html()).toBe('<nav role="navigation" class="navbar navbar-toggleable-md"></nav>');
+    expect(wrapper.html()).toBe('<nav class="navbar navbar-toggleable-md"></nav>');
   });
 
   it('should render custom tag', () => {
     const wrapper = shallow(<Navbar tag="div" />);
 
-    expect(wrapper.html()).toBe('<div role="navigation" class="navbar"></div>');
+    expect(wrapper.html()).toBe('<div class="navbar"></div>');
+  });
+
+  it('should render role', () => {
+    const wrapper = shallow(<Navbar role="navigation" />);
+
+    expect(wrapper.html()).toBe('<nav role="navigation" class="navbar"></nav>');
   });
 
-  it('sholid render children', () => {
+  it('should render children', () => {
     const wrapper = shallow(<Navbar>Children</Navbar>);
 
-    expect(wrapper.html()).toBe('<nav role="navigation" class="navbar">Children</nav>');
+    expect(wrapper.html()).toBe('<nav class="navbar">Children</nav>');
   });
 
   it('should pass additional classNames', () => {
