fix(PaginationLink): handle empty children array correctly (#511) (#604)

fabiob · TheSharpieOne · commit c090ea79e265 · 2017-10-01T22:32:42.000-04:00
diff --git a/src/PaginationLink.js b/src/PaginationLink.js
@@ -48,7 +48,7 @@ const PaginationLink = (props) => {
   }
 
   let children = props.children;
-  if (children && !children.length) {
+  if (children && Array.isArray(children) && children.length === 0) {
     children = null;
   }
 
diff --git a/src/__tests__/PaginationLink.spec.js b/src/__tests__/PaginationLink.spec.js
@@ -60,9 +60,15 @@ describe('PaginationLink', () => {
     expect(wrapper.find('.sr-only').text()).toBe('Yo');
   });
 
-  it('should render custom caret', () => {
+  it('should render custom caret specified as a string', () => {
     const wrapper = shallow(<PaginationLink next>Yo</PaginationLink>);
 
     expect(wrapper.find({ 'aria-hidden': 'true' }).text()).toBe('Yo');
   });
+
+  it('should render custom caret specified as a component', () => {
+    const wrapper = shallow(<PaginationLink next><span>Yo</span></PaginationLink>);
+
+    expect(wrapper.find({ 'aria-hidden': 'true' }).text()).toBe('Yo');
+  });
 });

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ const PaginationLink = (props) => {`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`let children = props.children;`
`51`		`- if (children && !children.length) {`
	`51`	`+ if (children && Array.isArray(children) && children.length === 0) {`
`52`	`52`	`children = null;`
`53`	`53`	`}`
`54`	`54`