Skip to content

Commit b9d3ea7

Browse files
committed
fix(Popover): remove old arrow markup, correct enabled className
1 parent d9e7621 commit b9d3ea7

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

src/Popover.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ const defaultProps = {
2323

2424
const defaultTetherConfig = {
2525
classPrefix: 'bs-tether',
26-
classes: { element: 'popover', enabled: 'open' },
26+
classes: {
27+
element: false,
28+
enabled: 'in'
29+
},
2730
constraints: [
2831
{ to: 'scrollParent', attachment: 'together none' },
2932
{ to: 'window', attachment: 'together none' }
@@ -63,7 +66,7 @@ class Popover extends React.Component {
6366

6467
return (
6568
<TetherContent
66-
arrow="popover"
69+
className="popover"
6770
tether={tetherConfig}
6871
tetherRef={this.props.tetherRef}
6972
isOpen={this.props.isOpen}

src/__tests__/Popover.spec.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ describe('Popover', () => {
6868
expect(isOpen).toBe(false);
6969

7070
expect(wrapper.find(TetherContent).length).toBe(0);
71+
expect(document.body.querySelectorAll('.popover.in').length).toBe(0);
7172
expect(document.getElementsByClassName('popover').length).toBe(0);
7273
expect(document.getElementsByClassName('popover-inner').length).toBe(0);
7374
expect(document.getElementsByClassName('popover-title').length).toBe(0);
@@ -80,6 +81,7 @@ describe('Popover', () => {
8081

8182
expect(isOpen).toBe(true);
8283
expect(wrapper.find(TetherContent).length).toBe(1);
84+
expect(document.body.querySelectorAll('.popover.in').length).toBe(1);
8385
expect(document.getElementsByClassName('popover').length).toBe(1);
8486
expect(document.getElementsByClassName('popover-inner').length).toBe(1);
8587
expect(document.getElementsByClassName('popover-title').length).toBe(1);

0 commit comments

Comments
 (0)