fix(Modal): use togglePortal on componentDidMount (#106)

eddywashere · web-flow · commit 942b24a5f844 · 2016-08-18T23:15:24.000-07:00
diff --git a/src/Modal.jsx b/src/Modal.jsx
@@ -31,7 +31,7 @@ class Modal extends React.Component {
 
   componentDidMount() {
     if (this.props.isOpen) {
-      this.show();
+      this.togglePortal();
     }
   }
 
diff --git a/test/Modal.spec.js b/test/Modal.spec.js
@@ -183,7 +183,7 @@ describe('Modal', () => {
 
     jasmine.clock().tick(300);
     expect(isOpen).toBe(true);
-    expect(Modal.prototype.togglePortal.calls.count()).toEqual(0);
+    expect(Modal.prototype.togglePortal.calls.count()).toEqual(1);
     expect(Modal.prototype.renderIntoSubtree.calls.count()).toEqual(1);
 
     wrapper.setProps({
@@ -192,7 +192,7 @@ describe('Modal', () => {
     jasmine.clock().tick(300);
 
     expect(isOpen).toBe(true);
-    expect(Modal.prototype.togglePortal.calls.count()).toEqual(0);
+    expect(Modal.prototype.togglePortal.calls.count()).toEqual(1);
     expect(Modal.prototype.renderIntoSubtree.calls.count()).toEqual(2);
 
     wrapper.unmount();

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class Modal extends React.Component {`
`31`	`31`
`32`	`32`	`componentDidMount() {`
`33`	`33`	`if (this.props.isOpen) {`
`34`		`- this.show();`
	`34`	`+ this.togglePortal();`
`35`	`35`	`}`
`36`	`36`	`}`
`37`	`37`