Commit 663551b
fix(ButtonDropdown): allow overwriting the group prop (#425)
* fix(ButtonDropdown) group={false} did nothing
The underlying Object.assign needs to have the overrides to the right it seems like
```function example(){
let props = {group: "FROM PROPERTIES" };
let propsOverwritten = Object.assign({}, props, {'group': "group from defaults"});
console.log("props first, groups overwritten", propsOverwritten);
let notOverwritten = Object.assign({}, {'group': "group from defaults"}, props);
console.log("groups first, overwritten by props as intended", notOverwritten);
}
example()
```
ES6 example https://es6console.com/j2paoelc/
Not crazy sure, but I changed the order in `reactstrap.es.js` of `g,{group:!0}` and it worked, so this seems like it would have the appropriate affect.
* fix extra space
* add space to fix lint rule1 parent 22d5c3f commit 663551b
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
0 commit comments