feat(Modal): Make toggle prop optional (#325)

bherila · eddywashere · commit 5e98ea350452 · 2017-02-14T08:55:27.000-08:00
* Make toggle prop optional on Modal re #323 * Check toggle prop for null
diff --git a/src/Modal.js b/src/Modal.js
@@ -14,7 +14,7 @@ import {
 const propTypes = {
   isOpen: PropTypes.bool,
   size: PropTypes.string,
-  toggle: PropTypes.func.isRequired,
+  toggle: PropTypes.func,
   keyboard: PropTypes.bool,
   backdrop: PropTypes.oneOfType([
     PropTypes.bool,
@@ -90,7 +90,7 @@ class Modal extends React.Component {
   }
 
   handleEscape(e) {
-    if (this.props.keyboard && e.keyCode === 27) {
+    if (this.props.keyboard && e.keyCode === 27 && this.props.toggle) {
       this.props.toggle();
     }
   }
@@ -100,7 +100,7 @@ class Modal extends React.Component {
 
     const container = this._dialog;
 
-    if (e.target && !container.contains(e.target)) {
+    if (e.target && !container.contains(e.target) && this.props.toggle) {
       this.props.toggle();
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ import {`
`14`	`14`	`const propTypes = {`
`15`	`15`	`isOpen: PropTypes.bool,`
`16`	`16`	`size: PropTypes.string,`
`17`		`- toggle: PropTypes.func.isRequired,`
	`17`	`+ toggle: PropTypes.func,`
`18`	`18`	`keyboard: PropTypes.bool,`
`19`	`19`	`backdrop: PropTypes.oneOfType([`
`20`	`20`	`PropTypes.bool,`
`@@ -90,7 +90,7 @@ class Modal extends React.Component {`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`handleEscape(e) {`
`93`		`- if (this.props.keyboard && e.keyCode === 27) {`
	`93`	`+ if (this.props.keyboard && e.keyCode === 27 && this.props.toggle) {`
`94`	`94`	`this.props.toggle();`
`95`	`95`	`}`
`96`	`96`	`}`
`@@ -100,7 +100,7 @@ class Modal extends React.Component {`
`100`	`100`
`101`	`101`	`const container = this._dialog;`
`102`	`102`
`103`		`- if (e.target && !container.contains(e.target)) {`
	`103`	`+ if (e.target && !container.contains(e.target) && this.props.toggle) {`
`104`	`104`	`this.props.toggle();`
`105`	`105`	`}`
`106`	`106`	`}`